Bugfix: Prevent segfault when butcher target disappears #73990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stops butchering when the butcher target corpse has been either raised or moved. Prevents segfault caused by dereferencing an invalid `item_location`.
github-actions
bot
added
[C++]
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Prevent segfault when butcher target disappears"
Purpose of change
Stops butchering when the butcher target corpse has been either raised or moved. Prevents segfault caused by dereferencing an invalid
item_location.Fixes #73985 . Fixes #73978 .
Describe the solution
Adds the check in
butcher_do_turnsuggested by #73978 (comment)Describe alternatives you've considered
Testing
Tested the steps in #73985 and #73978 . Cannot reproduce the segfault on this branch.
Additional context
From #73610 .